From: martin.petersen@oracle.com (Martin K. Petersen)
Subject: [PATCH] nvme: set physical block size to value discovered in Identify Namespace
Date: Wed, 20 Sep 2017 16:01:58 -0400 [thread overview]
Message-ID: <yq1fubhkukp.fsf@oracle.com> (raw)
In-Reply-To: <20170920190752.GC1379@localhost.localdomain> (Keith Busch's message of "Wed, 20 Sep 2017 15:07:52 -0400")
Keith,
> I don't think it's about "reasonable" performance; it's about getting
> extra relative performance. What else can the best performing LBAF
> indicate other than the device's preferred access alignment/granularity?
> The spec provides this hint, so it's not really a guess, but maybe
> there's a better way to make use of it instead of considering it to be
> the physical block size? io_opt?
It should really report io_min and not physical_block_size. pbs is a
special case for spinning media.
I agree it's a bit weird to walk the format list as a heuristic. Would
be nicer to have a smallest preferred I/O size in the protocol.
> The first and last are the exact same NVMe format, but they're
> reported differently.
Yeah, we should set pbs/io_min as well.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-09-20 20:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 17:06 [PATCH] nvme: set physical block size to value discovered in Identify Namespace Andrzej Jakowski
2017-09-20 17:48 ` Keith Busch
2017-09-20 17:48 ` Christoph Hellwig
2017-09-20 19:07 ` Keith Busch
2017-09-20 20:01 ` Martin K. Petersen [this message]
2017-09-20 20:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1fubhkukp.fsf@oracle.com \
--to=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.