From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH/RFC V2 07/16] scsi: support well known logical units Date: Thu, 21 Aug 2014 17:18:53 -0400 Message-ID: References: <1408023067-26103-1-git-send-email-draviv@codeaurora.org> <1408023067-26103-8-git-send-email-draviv@codeaurora.org> <20140819172251.GA12892@infradead.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:25099 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754015AbaHUVTZ (ORCPT ); Thu, 21 Aug 2014 17:19:25 -0400 In-Reply-To: <20140819172251.GA12892@infradead.org> (Christoph Hellwig's message of "Tue, 19 Aug 2014 12:22:51 -0500") Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Christoph Hellwig Cc: Dolev Raviv , James.Bottomley@HansenPartnership.com, linux-scsi@vger.kernel.org, linux-scsi-owner@vger.kernel.org, linux-arm-msm@vger.kernel.org, santoshsy@gmail.com, Subhash Jadavani , Sujit Reddy Thumma , Hannes Reinecke , "Martin K. Petersen" >>>>> "Christoph" == Christoph Hellwig writes: >> + /* >> + * put runtime pm reference for well-known logical units, >> + * drivers are expected to _get_* again during probe. >> + */ >> + if (scsi_is_wlun(sdev->lun)) >> + scsi_autopm_put_device(sdev); Christoph> Special casing the well known LUNs here seems wrong. Christoph> Shouldn't we do this for any devices that don't get a driver Christoph> attached to them? That would also be my preference. Relying on WLU for this seems like a kludge. -- Martin K. Petersen Oracle Linux Engineering