From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH 1/3] scsi_debug: scsi_cmnd->cmnd check and casts unnecessary Date: Mon, 18 Aug 2014 08:37:28 -0400 Message-ID: References: <53E0AFD2.3050202@interlog.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:46419 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751258AbaHRMhf (ORCPT ); Mon, 18 Aug 2014 08:37:35 -0400 In-Reply-To: <53E0AFD2.3050202@interlog.com> (Douglas Gilbert's message of "Tue, 05 Aug 2014 12:20:02 +0200") Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: dgilbert@interlog.com Cc: SCSI development list , Christoph Hellwig , Dan Carpenter >>>>> "Doug" == Douglas Gilbert writes: Doug> This patch removes a NULL check for the scsi_cmnd::cmnd pointer Doug> since many other instances in this driver and elsewhere assume it Doug> is valid. Also redundant casts to 'unsigned char *' are removed as Doug> the pointer has that type. Doug> Signed-off-by: Douglas Gilbert Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering