All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Andrey Melnikov <temnota.am@gmail.com>
Cc: Zhong Li <lizhongfs@gmail.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org
Subject: Re: [RFC,v2] scsi: scan: map PQ=1, PDT=other values to SCSI_SCAN_TARGET_PRESENT
Date: Thu, 26 Sep 2019 19:26:18 -0400	[thread overview]
Message-ID: <yq1h84y1vxh.fsf@oracle.com> (raw)
In-Reply-To: <CA+PODjpG7NLTH8wp9qw08ACj4=8sUusmkZv6X7QWHtdbNJ1S0Q@mail.gmail.com> (Andrey Melnikov's message of "Thu, 12 Sep 2019 15:37:20 +0300")


Andrey,

>> > This patch break exposing individual RAID disks from adaptec raid
>> > controller. I need access to this disc's for S.M.A.R.T monitoring.
>
> adaptec report hidden luns with PQ=1, PDT=0 - now it skipped.

>> > Please find other way to workaround bugs in IBM/2145 controller.

Spent some time on this today and I'm in agreement with Zhong's
interpretation of the SCSI spec.

What puzzles me is that aacraid already supports the no_uld_attach
feature so I'm not sure why it also sets PQ=1 for physical devices?

We could either have a SCSI host flag to override the behavior or
consider masking PQ in the driver. Unfortunately, I don't have any
aacraid controllers I can test with in my test setup so I'd have to
synthesize a setup with scsi_debug.

-- 
Martin K. Petersen	Oracle Linux Engineering

  parent reply	other threads:[~2019-09-26 23:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-29 15:49 [RFC,v2] scsi: scan: map PQ=1, PDT=other values to SCSI_SCAN_TARGET_PRESENT Andrey Melnikov
2019-09-12  4:56 ` Zhong Li
2019-09-12 12:37   ` Andrey Melnikov
2019-09-22 12:07     ` Li Zhong
2019-09-26 23:26     ` Martin K. Petersen [this message]
2019-09-27 14:16       ` Hannes Reinecke
2019-10-01  1:53         ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1h84y1vxh.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lizhongfs@gmail.com \
    --cc=temnota.am@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.