From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Sathya Prakash <sathya.prakash@broadcom.com>,
Chaitra P B <chaitra.basappa@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] mptlan: fix mpt_lan_sdu_send()'s return type
Date: Tue, 08 May 2018 01:21:56 -0400 [thread overview]
Message-ID: <yq1h8niyb63.fsf@oracle.com> (raw)
In-Reply-To: <20180424131558.3010-1-luc.vanoostenryck@gmail.com> (Luc Van Oostenryck's message of "Tue, 24 Apr 2018 15:15:58 +0200")
Luc,
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, but the implementation in this
> driver returns an 'int'.
You forgot to update the function prototype accordingly.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-05-08 5:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 13:15 [PATCH] mptlan: fix mpt_lan_sdu_send()'s return type Luc Van Oostenryck
2018-05-08 5:21 ` Martin K. Petersen [this message]
2018-05-08 15:44 ` Luc Van Oostenryck
2018-05-15 2:51 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1h8niyb63.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=chaitra.basappa@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=sathya.prakash@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.