From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "chenxiang (M)" <chenxiang66@hisilicon.com>
Cc: martin.petersen@oracle.com, jejb@linux.vnet.ibm.com,
john.garry@huawei.com, linux-scsi@vger.kernel.org,
linuxarm@huawei.com, bryantly@linux.vnet.ibm.com,
mikecyr@linux.vnet.ibm.com, artur.paszkiewicz@intel.com,
dan.j.williams@intel.com, yuxiangl@marvell.com,
jgarzik@pobox.com, jack_wang@usish.com, lindar_liu@usish.com,
xjtuwjp@gmail.com
Subject: Re: [PATCH v2 0/4] fix dma_unmap_sg() parameter in some scsi drivers
Date: Mon, 22 Jan 2018 19:45:23 -0500 [thread overview]
Message-ID: <yq1h8rdiesc.fsf@oracle.com> (raw)
In-Reply-To: <c7f7ba3f-9a0f-e251-27f6-0ad582d8a88e@hisilicon.com> (chenxiang's message of "Mon, 22 Jan 2018 15:50:28 +0800")
Chenxiang,
> does anyone notice and review this issue?
It's a pretty crappy interface that has to have explanatory "notes"
throughout the documentation saying "Don't use this the obvious way, do
this instead". As evidenced by 5 drivers messing it up.
Your change looks good to me. But before I apply I'd like somebody from
the IBM camp to verify that fixing this doesn't unintentionally break
stuff on power.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2018-01-23 0:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 2:36 [PATCH v2 0/4] fix dma_unmap_sg() parameter in some scsi drivers chenxiang
2018-01-04 2:36 ` [PATCH v2 1/4] scsi: ibmvscsis: fix dma_unmap_sg() parameter chenxiang
2018-01-04 2:36 ` [PATCH v2 2/4] scsi: isci: " chenxiang
2018-01-04 2:36 ` [PATCH v2 3/4] scsi: mvsas: " chenxiang
2018-01-04 2:36 ` [PATCH v2 4/4] scsi: pm8001: " chenxiang
2018-01-08 8:53 ` chenxiang (M)
2018-01-22 7:50 ` [PATCH v2 0/4] fix dma_unmap_sg() parameter in some scsi drivers chenxiang (M)
2018-01-23 0:45 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1h8rdiesc.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=artur.paszkiewicz@intel.com \
--cc=bryantly@linux.vnet.ibm.com \
--cc=chenxiang66@hisilicon.com \
--cc=dan.j.williams@intel.com \
--cc=jack_wang@usish.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jgarzik@pobox.com \
--cc=john.garry@huawei.com \
--cc=lindar_liu@usish.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mikecyr@linux.vnet.ibm.com \
--cc=xjtuwjp@gmail.com \
--cc=yuxiangl@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.