From: martin.petersen@oracle.com (Martin K. Petersen)
Subject: [PATCHv2] nvme/pci: Print invalid SGL only once
Date: Fri, 15 Sep 2017 21:05:28 -0400 [thread overview]
Message-ID: <yq1h8w3tpuv.fsf@oracle.com> (raw)
In-Reply-To: <1505495138-11325-1-git-send-email-keith.busch@intel.com> (Keith Busch's message of "Fri, 15 Sep 2017 13:05:38 -0400")
Keith,
> The WARN_ONCE macro returns true if the condition is true, not if the
> warn was raised, so we're printing the scatter list every time it's
> invalid. This is excessive and makes debugging harder, so this patch
> prints it just once.
Reviewed-by: Martin K. Petersen <martin.petersen at oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-09-16 1:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 17:05 [PATCHv2] nvme/pci: Print invalid SGL only once Keith Busch
2017-09-15 17:45 ` Christoph Hellwig
2017-09-16 1:02 ` Martin K. Petersen
2017-09-16 1:05 ` Martin K. Petersen [this message]
2017-09-18 7:57 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1h8w3tpuv.fsf@oracle.com \
--to=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.