All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"André Draszik" <andre.draszik@linaro.org>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Peter Wang" <peter.wang@mediatek.com>,
	"Ziqi Chen" <quic_ziqichen@quicinc.com>,
	"Can Guo" <quic_cang@quicinc.com>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Bao D. Nguyen" <quic_nguyenb@quicinc.com>,
	"Bean Huo" <beanhuo@micron.com>
Subject: Re: [PATCH] ufs: core: Fix single doorbell mode support
Date: Wed, 19 Nov 2025 12:04:13 -0500	[thread overview]
Message-ID: <yq1ikf6ar98.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20251114193406.3097237-1-bvanassche@acm.org> (Bart Van Assche's message of "Fri, 14 Nov 2025 11:34:03 -0800")


Bart,

> Commit 22089c218037 ("scsi: ufs: core: Optimize the hot path")
> accidentally broke support for the legacy single doorbell mode. The
> tag_set.shared_tags pointer is only != NULL if shared tag support is
> enabled. The UFS driver only enables shared tag support in MCQ mode.
>
> Fix this by handling legacy and MCQ modes differently in
> ufshcd_tag_to_cmd().

Applied to 6.19/scsi-staging, thanks!

-- 
Martin K. Petersen

  parent reply	other threads:[~2025-11-19 17:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14 19:34 [PATCH] ufs: core: Fix single doorbell mode support Bart Van Assche
2025-11-15 16:10 ` André Draszik
2025-11-19 17:04 ` Martin K. Petersen [this message]
2025-11-29  3:30 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1ikf6ar98.fsf@ca-mkp.ca.oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=andre.draszik@linaro.org \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mani@kernel.org \
    --cc=peter.wang@mediatek.com \
    --cc=quic_cang@quicinc.com \
    --cc=quic_nguyenb@quicinc.com \
    --cc=quic_ziqichen@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.