From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: martin.petersen@oracle.com, Jens Axboe <axboe@kernel.dk>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: please revert the UFS HPB support
Date: Fri, 22 Oct 2021 21:54:44 -0400 [thread overview]
Message-ID: <yq1ilxp68x3.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20211021144210.GA28195@lst.de> (Christoph Hellwig's message of "Thu, 21 Oct 2021 16:42:10 +0200")
Hi Christoph,
> I just noticed the UFS HPB support landed in 5.15, and just as before
> it is completely broken by allocating another request on the same
> device and then reinserting it in the queue. It is bad enough that we
> have to live with blk_insert_cloned_request for dm-mpath, but this is
> too big of an API abuse to make it into a release. We need to drop
> this code ASAP, and I can prepare a patch for that.
The series went through 40 iterations on the list prior to being merged.
I don't recall a better approach to reconcile the HPB model with the
stack being offered during that process?
As much as I don't like HPB, all the major UFS subsystem stakeholders
are behind it. The hardware is shipping and various device stacks
already adopted support for it. At this stage I don't think dropping the
code is a way forward. I am much more in favor of having a productive
discussion about how to go about addressing the problems with the
queuing model...
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2021-10-23 1:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 14:42 please revert the UFS HPB support Christoph Hellwig
2021-10-21 15:13 ` Jens Axboe
2021-10-21 15:15 ` Christoph Hellwig
2021-10-21 15:17 ` Christoph Hellwig
2021-10-21 16:22 ` Bart Van Assche
2021-10-23 15:43 ` James Bottomley
2021-10-25 5:16 ` Daejun Park
2021-10-25 7:07 ` Christoph Hellwig
2021-10-25 11:39 ` James Bottomley
2021-10-26 14:05 ` Adrian Hunter
2021-10-23 1:54 ` Martin K. Petersen [this message]
2021-10-23 4:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1ilxp68x3.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.