From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: Nilesh Javali <njavali@marvell.com>,
Arun Easi <aeasi@marvell.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] qla2xxx: Do not consume srb greedily
Date: Wed, 07 Oct 2020 22:19:39 -0400 [thread overview]
Message-ID: <yq1imblzcgi.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20200929073802.18770-1-dwagner@suse.de> (Daniel Wagner's message of "Tue, 29 Sep 2020 09:38:02 +0200")
Daniel,
> qla2xx_process_get_sp_from_handle() will clear the slot which the
> current srb is stored. So this function has a side effect. Therefore,
> we can't use it in qla24xx_process_mbx_iocb_response() to check
> for consistency and later again in qla24xx_mbx_iocb_entry().
>
> Let's move the consistency check directly into
> qla24xx_mbx_iocb_entry() and avoid the double call or any open coding
> of the qla2xx_process_get_sp_from_handle() functionality.
Applied to 5.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-10-08 2:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 7:38 [PATCH] qla2xxx: Do not consume srb greedily Daniel Wagner
2020-10-05 7:42 ` Daniel Wagner
2020-10-07 13:54 ` Himanshu Madhani
2020-10-07 17:05 ` Arun Easi
2020-10-08 2:19 ` Martin K. Petersen [this message]
2020-10-13 22:42 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1imblzcgi.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=aeasi@marvell.com \
--cc=dwagner@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=njavali@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.