From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Alex Dewar <alex.dewar@gmx.co.uk>
Cc: Hannes Reinecke <hare@suse.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: aic7xxx: Remove unnecessary NULL checks before kfree
Date: Fri, 24 Apr 2020 12:49:41 -0400 [thread overview]
Message-ID: <yq1imhoesm2.fsf@oracle.com> (raw)
In-Reply-To: <20200403164712.49579-1-alex.dewar@gmx.co.uk> (Alex Dewar's message of "Fri, 3 Apr 2020 17:47:11 +0100")
Alex,
> There are a number of places in the aic7xxx driver where a NULL check
> is performed before a kfree(). However, kfree() already performs NULL
> checks so this is unnecessary. Remove the checks.
>
> Issue identified with Coccinelle.
Applied to 5.8/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-04-24 16:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 16:47 [PATCH] scsi: aic7xxx: Remove unnecessary NULL checks before kfree Alex Dewar
2020-04-24 16:49 ` Martin K. Petersen [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-04 9:00 Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1imhoesm2.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=alex.dewar@gmx.co.uk \
--cc=hare@suse.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.