From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Anand Lodnoor <anand.lodnoor@broadcom.com>
Cc: linux-scsi@vger.kernel.org, kashyap.desai@broadcom.com,
sumit.saxena@broadcom.com, kiran-kumar.kasturi@broadcom.com,
Chandrakanth Patil <chandrakanth.patil@broadcom.com>
Subject: Re: [PATCH 01/11] megaraid_sas: Add transition_to_ready retry logic in resume path
Date: Fri, 10 Jan 2020 01:00:35 -0500 [thread overview]
Message-ID: <yq1imljx33w.fsf@oracle.com> (raw)
In-Reply-To: <1578051155-14716-2-git-send-email-anand.lodnoor@broadcom.com> (Anand Lodnoor's message of "Fri, 3 Jan 2020 17:02:25 +0530")
Hi Anand,
First of all, you need a better commit descriptions with a rationale for
each change. Several of the patches in the posted series have vague
one-liners.
In addition, this hunk seems odd:
> + if (megasas_adp_reset_wait_for_ready
> + (instance, true, 0) == FAILED)
> + goto fail_ready_state;
> + } else {
> + goto fail_ready_state;
> + }
Couple of typos. And please add a space after /* and before */:
> + /*waitting for about 30 second before retry*/
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-01-10 6:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 11:32 [PATCH 00/11] megaraid_sas: driver updates to 07.713.01.00-rc1 Anand Lodnoor
2020-01-03 11:32 ` [PATCH 01/11] megaraid_sas: Add transition_to_ready retry logic in resume path Anand Lodnoor
2020-01-10 6:00 ` Martin K. Petersen [this message]
2020-01-03 11:32 ` [PATCH 02/11] megaraid_sas: Set no_write_same only for Virtual Disk Anand Lodnoor
2020-01-03 11:32 ` [PATCH 03/11] megaraid_sas: Update queue_depth of SAS and NVMe devices Anand Lodnoor
2020-01-10 6:03 ` Martin K. Petersen
2020-01-03 11:32 ` =?y?q?=5BPATCH=2004/11=5D=20megaraid=5Fsas=3A=20Don=E2=80=99t=20kill=20already=20dead=20adapter?= Anand Lodnoor
2020-01-10 6:03 ` .PATCH.04/11.megaraid.sas.Don.t.kill.already.dead.adapter Martin K. Petersen
2020-01-03 11:32 ` [PATCH 05/11] megaraid_sas: Do not kill HBA if JBOD Seqence map or RAID map is disabled Anand Lodnoor
2020-01-03 11:32 ` [PATCH 06/11] megaraid_sas: Do not set HBA Operational if FW is not in operational state Anand Lodnoor
2020-01-03 11:32 ` [PATCH 07/11] megaraid_sas: Re-Define enum DCMD_RETURN_STATUS Anand Lodnoor
2020-01-03 11:32 ` [PATCH 08/11] megaraid_sas: Do not initiate OCR if controller is not in ready state Anand Lodnoor
[not found] ` <20200104053110.9D26124649@mail.kernel.org>
2020-01-07 7:59 ` Sumit Saxena
2020-01-03 11:32 ` [PATCH 09/11] megaraid_sas: Return pended IOCTLs after 3 retries Anand Lodnoor
2020-01-03 11:32 ` [PATCH 10/11] megaraid_sas: Use Block layer API to check SCSI device in-flight IO requests Anand Lodnoor
2020-01-03 11:32 ` [PATCH 11/11] megaraid_sas: Update driver version to 07.713.01.00-rc1 Anand Lodnoor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1imljx33w.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=anand.lodnoor@broadcom.com \
--cc=chandrakanth.patil@broadcom.com \
--cc=kashyap.desai@broadcom.com \
--cc=kiran-kumar.kasturi@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.