From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Don.Brace@microchip.com
Cc: erwanaliasr1@gmail.com, e.velu@criteo.com,
don.brace@microsemi.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, esc.storagedev@microsemi.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: smartpqi: Reporting unhandled SCSI errors
Date: Mon, 13 May 2019 20:30:10 -0400 [thread overview]
Message-ID: <yq1imudg9nx.fsf@oracle.com> (raw)
In-Reply-To: <SN6PR11MB2767E3FB513853E9666779B9E13B0@SN6PR11MB2767.namprd11.prod.outlook.com> (Don Brace's message of "Wed, 1 May 2019 14:22:11 +0000")
>> When a HARDWARE_ERROR is triggered for asc=0x3e, the actual code is
>> only considering the case where ascq=0x1.
>>
>> Following the http://www.t10.org/lists/asc-num.htm#ASC_3E
>> specification, other values may occur like a timeout (ascq=0x2).
>>
>> This patch is about printing an error message when a non-handled
>> message is received. This could help diagnose a possible
>> miss-behavior of the controller and/or a missing implementation in
>> the Linux Kernel.
>>
>> This patch keeps the exact same error handling but prints a message
>> if an ascq != 1 income.
>>
>> Signed-off-by: Erwan Velu <e.velu@criteo.com>
> Acked-by: Don Brace <don.brace@microsemi.com>
Applied to 5.2/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: <Don.Brace@microchip.com>
Cc: <erwanaliasr1@gmail.com>, <e.velu@criteo.com>,
<don.brace@microsemi.com>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>, <esc.storagedev@microsemi.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: smartpqi: Reporting unhandled SCSI errors
Date: Mon, 13 May 2019 20:30:10 -0400 [thread overview]
Message-ID: <yq1imudg9nx.fsf@oracle.com> (raw)
In-Reply-To: <SN6PR11MB2767E3FB513853E9666779B9E13B0@SN6PR11MB2767.namprd11.prod.outlook.com> (Don Brace's message of "Wed, 1 May 2019 14:22:11 +0000")
>> When a HARDWARE_ERROR is triggered for asc=0x3e, the actual code is
>> only considering the case where ascq=0x1.
>>
>> Following the http://www.t10.org/lists/asc-num.htm#ASC_3E
>> specification, other values may occur like a timeout (ascq=0x2).
>>
>> This patch is about printing an error message when a non-handled
>> message is received. This could help diagnose a possible
>> miss-behavior of the controller and/or a missing implementation in
>> the Linux Kernel.
>>
>> This patch keeps the exact same error handling but prints a message
>> if an ascq != 1 income.
>>
>> Signed-off-by: Erwan Velu <e.velu@criteo.com>
> Acked-by: Don Brace <don.brace@microsemi.com>
Applied to 5.2/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-05-14 0:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 9:49 [PATCH] scsi: smartpqi: Reporting unhandled SCSI errors Erwan Velu
2019-03-21 9:49 ` Erwan Velu
2019-04-10 11:02 ` Erwan Velu
2019-04-10 11:02 ` Erwan Velu
2019-05-01 14:22 ` Don.Brace
2019-05-01 14:22 ` Don.Brace
2019-05-14 0:30 ` Martin K. Petersen [this message]
2019-05-14 0:30 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1imudg9nx.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=Don.Brace@microchip.com \
--cc=don.brace@microsemi.com \
--cc=e.velu@criteo.com \
--cc=erwanaliasr1@gmail.com \
--cc=esc.storagedev@microsemi.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.