From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Hannes Reinecke <hare@suse.com>,
Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: [PATCH 1/3] device information: Do not interpret error codes as flags
Date: Wed, 15 Nov 2017 18:57:03 -0500 [thread overview]
Message-ID: <yq1inebqenk.fsf@oracle.com> (raw)
In-Reply-To: <20171115023317.3595-2-bart.vanassche@wdc.com> (Bart Van Assche's message of "Tue, 14 Nov 2017 18:33:15 -0800")
Hi Bart,
> This patch also avoids that error codes returned by
> scsi_get_device_flags_keyed() are interpret as device flags.
Nobody expects this and scsi_get_device_flags() to ever return an
error. So I'd rather have the != -ENOENT case fixed up to return 0.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-11-15 23:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 2:33 [PATCH 0/3] Improve device information handling Bart Van Assche
2017-11-15 2:33 ` [PATCH 1/3] device information: Do not interpret error codes as flags Bart Van Assche
2017-11-15 23:57 ` Martin K. Petersen [this message]
2017-11-15 2:33 ` [PATCH 2/3] Constify scsi_dev_info_list_add_keyed() string arguments Bart Van Assche
2017-11-15 2:33 ` [PATCH 3/3] Introduce a type for device information flags, namely bflags_t Bart Van Assche
2017-11-16 0:00 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2017-11-15 0:57 [PATCH 0/3] Improve device information handling Bart Van Assche
2017-11-15 0:57 ` [PATCH 1/3] device information: Do not interpret error codes as flags Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1inebqenk.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=bart.vanassche@wdc.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.