From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Anil Gurumurthy <anil.gurumurthy@qlogic.com>,
Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: bfa: Replace kzalloc + copy_from_user with memdup_user
Date: Mon, 29 Sep 2025 16:49:02 -0400 [thread overview]
Message-ID: <yq1jz1hnggp.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <F0B8FDF9-027D-4CCD-A5CA-91E7B2FF4950@linux.dev> (Thorsten Blum's message of "Thu, 25 Sep 2025 20:13:09 +0200")
Hi Thorsten!
>>> No functional changes intended other than returning the more
>>> idiomatic error code -EFAULT.
>>
>> How can we be sure that this doesn't break existing applications?
>
> I guess we can't because the error code is returned to userspace as
> the result of a bsg_job? That wasn't immediately obvious to me.
Correct. And with little chance of having the associated management
utilities updated, it's best to leave things as they are.
--
Martin K. Petersen
prev parent reply other threads:[~2025-09-29 20:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 14:40 [PATCH] scsi: bfa: Replace kzalloc + copy_from_user with memdup_user Thorsten Blum
2025-09-25 2:10 ` Martin K. Petersen
2025-09-25 18:13 ` Thorsten Blum
2025-09-29 20:49 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1jz1hnggp.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=anil.gurumurthy@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sudarsana.kalluru@qlogic.com \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.