From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Varun Prakash <varun@chelsio.com>,
linux-kernel@vger.kernel.org,
Philippe Ombredanne <pombredanne@nexb.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: csiostor: remove unneeded DRIVER_LICENSE #define
Date: Mon, 20 Nov 2017 22:15:45 -0500 [thread overview]
Message-ID: <yq1k1ykmie6.fsf@oracle.com> (raw)
In-Reply-To: <20171117142122.GF17880@kroah.com> (Greg Kroah-Hartman's message of "Fri, 17 Nov 2017 15:21:22 +0100")
Greg,
> There is no need to #define the license of the driver, just put it in
> the MODULE_LICENSE() line directly as a text string.
>
> This allows tools that check that the module license matches the source
> code license to work properly, as there is no need to unwind the
> unneeded dereference, especially when the string is defined in a .h file
> far away from the .c file it is used in.
Applied to 4.16/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-11-21 3:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 14:21 [PATCH] scsi: csiostor: remove unneeded DRIVER_LICENSE #define Greg Kroah-Hartman
2017-11-17 14:54 ` Philippe Ombredanne
2017-11-21 3:15 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1k1ykmie6.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.