From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Bart Van Assche <Bart.VanAssche@wdc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"hch@lst.de" <hch@lst.de>,
"james.bottomley@hansenpartnership.com"
<james.bottomley@hansenpartnership.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"hare@suse.com" <hare@suse.com>,
"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>
Subject: Re: [PATCHv3 2/5] scsi: Export blacklist flags to sysfs
Date: Wed, 16 Aug 2017 20:10:50 -0400 [thread overview]
Message-ID: <yq1k223qcj9.fsf@oracle.com> (raw)
In-Reply-To: <b4309af8-210b-04e1-e541-f58455fc4bc1@suse.de> (Hannes Reinecke's message of "Wed, 16 Aug 2017 07:56:19 +0200")
Hannes,
> I still would like to keep the above, as the admin can feed blacklist
> flags via the kernel commandline, and we don't do any validity checks on
> that. So we might end up with invalid flags after all.
I suggest you handle this by printing something along the lines of
"INVALID_BIT_SET(42)" for each bad flag.
Also: Brownie points for adding a new sysfs interface to augment the
existing /proc goo for adding entries. Preferably one that takes BLIST
names instead of huge hex numbers.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-08-17 0:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 14:23 [PATCHv3 0/5] Hi all, Hannes Reinecke
2017-08-11 14:23 ` [PATCHv3 1/5] scsi_debug: allow to specify inquiry vendor and model Hannes Reinecke
2017-08-15 22:41 ` Bart Van Assche
2017-08-11 14:23 ` [PATCHv3 2/5] scsi: Export blacklist flags to sysfs Hannes Reinecke
2017-08-15 3:18 ` Martin K. Petersen
2017-08-15 8:03 ` Hannes Reinecke
2017-08-15 22:47 ` Bart Van Assche
2017-08-16 5:56 ` Hannes Reinecke
2017-08-17 0:10 ` Martin K. Petersen [this message]
2017-08-16 2:09 ` Martin K. Petersen
2017-08-15 14:24 ` Bart Van Assche
2017-08-15 14:40 ` Hannes Reinecke
2017-08-16 2:03 ` Martin K. Petersen
2017-08-11 14:23 ` [PATCHv3 3/5] scsi_devinfo: Reformat blacklist flags Hannes Reinecke
2017-08-15 22:52 ` Bart Van Assche
2017-08-16 5:56 ` Hannes Reinecke
2017-08-11 14:23 ` [PATCHv3 4/5] scsi: whitespace fixes in scsi_devinfo.c Hannes Reinecke
2017-08-11 14:23 ` [PATCHv3 5/5] scsi_devinfo: fixup string compare Hannes Reinecke
2017-08-11 15:08 ` Alan Stern
2017-08-15 23:03 ` Bart Van Assche
2017-08-16 5:57 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1k223qcj9.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=Bart.VanAssche@wdc.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.