From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Ewan D. Milne" <emilne@redhat.com>
Cc: linux-scsi@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH RESEND] scsi: Add STARGET_CREATED_REMOVE state to scsi_target_state
Date: Sat, 01 Jul 2017 16:55:46 -0400 [thread overview]
Message-ID: <yq1k23rx4fh.fsf@oracle.com> (raw)
In-Reply-To: <1498589758-31473-1-git-send-email-emilne@redhat.com> (Ewan D. Milne's message of "Tue, 27 Jun 2017 14:55:58 -0400")
Ewan,
> The addition of the STARGET_REMOVE state had the side effect of
> introducing a race condition that can cause a crash.
>
> scsi_target_reap_ref_release() checks the starget->state to
> see if it still in STARGET_CREATED, and if so, skips calling
> transport_remove_device() and device_del(), because the starget->state
> is only set to STARGET_RUNNING after scsi_target_add() has called
> device_add() and transport_add_device().
Applied to 4.13/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-07-01 20:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 18:55 [PATCH RESEND] scsi: Add STARGET_CREATED_REMOVE state to scsi_target_state Ewan D. Milne
2017-06-27 21:26 ` Laurence Oberman
2017-06-28 1:09 ` Martin K. Petersen
2017-06-28 7:38 ` Johannes Thumshirn
2017-06-28 7:38 ` Johannes Thumshirn
2017-06-28 14:23 ` Ewan D. Milne
2017-07-01 20:55 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1k23rx4fh.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=emilne@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.