From: "Martin K. Petersen" <mkp@kernel.org>
To: <shao.mingyin@zte.com.cn>
Cc: <mkp@kernel.org>, <james.bottomley@hansenpartnership.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: scsi_devinfo: return an error when the proc write fails
Date: Sun, 08 Nov 2026 22:18:34 -0500 [thread overview]
Message-ID: <yq1ld72wv42.fsf@mail.kernel.org> (raw)
In-Reply-To: <20261031222133489hI-BEIDpFMxrtlntnLiFb@zte.com.cn>
> proc_scsi_devinfo_write() calls scsi_dev_info_list_add_str() but
> ignores its return value, so a write to /proc/scsi/device_info always
> reports success, even when the string is malformed and no entry was
> added. Users and scripts then believe that the quirk is in effect.
Applied to 7.5/scsi-staging, thanks!
--
Martin K. Petersen
prev parent reply other threads:[~2026-11-09 3:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-31 14:21 [PATCH] scsi: scsi_devinfo: return an error when the proc write fails shao.mingyin
2026-10-31 19:31 ` Laurence Oberman
2026-11-09 3:18 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1ld72wv42.fsf@mail.kernel.org \
--to=mkp@kernel.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=shao.mingyin@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.