All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Showrya M N <showrya@chelsio.com>
Cc: <lduncan@suse.com>, <michael.christie@oracle.com>,
	<martin.petersen@oracle.com>, <cleech@redhat.com>,
	<linux-scsi@vger.kernel.org>, <bharat@chelsio.com>
Subject: Re: [PATCH for-rc] scsi: libiscsi: initialize iscsi_conn->dd_data only if memory is allocated
Date: Mon, 21 Jul 2025 23:48:53 -0400	[thread overview]
Message-ID: <yq1ldogx4va.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20250627112329.19763-1-showrya@chelsio.com> (Showrya M. N.'s message of "Fri, 27 Jun 2025 16:53:29 +0530")


Showrya,

> In case of an ib_fast_reg_mr allocation failure during iSER setup, the
> machine hits a panic because iscsi_conn->dd_data is initialized
> unconditionally, even when no memory is allocated (dd_size == 0). This
> leads invalid pointer dereference during connection teardown.
>
> Fix by setting iscsi_conn->dd_data only if memory is actually
> allocated.

Applied to 6.17/scsi-staging, thanks!

-- 
Martin K. Petersen

  parent reply	other threads:[~2025-07-22  3:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-27 11:23 [PATCH for-rc] scsi: libiscsi: initialize iscsi_conn->dd_data only if memory is allocated Showrya M N
2025-07-15  1:31 ` Martin K. Petersen
2025-07-15 17:49 ` Chris Leech
2025-07-22  3:48 ` Martin K. Petersen [this message]
2025-07-25  3:00 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1ldogx4va.fsf@ca-mkp.ca.oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=bharat@chelsio.com \
    --cc=cleech@redhat.com \
    --cc=lduncan@suse.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michael.christie@oracle.com \
    --cc=showrya@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.