From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH 4/8] scsi: remove the cmd field from struct scsi_request
Date: Tue, 22 Feb 2022 22:31:20 -0500 [thread overview]
Message-ID: <yq1ley2b6rw.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20220222140443.589882-5-hch@lst.de> (Christoph Hellwig's message of "Tue, 22 Feb 2022 15:04:39 +0100")
Christoph,
> Change all submitters of SCSI passthrough request to store the CDB
> information directly in the scsi_cmnd, and while doing so allocate the
> full 32 bytes that cover all Linux supported SCSI hosts instead of
> requiring dynamic allocation for > 16 byte CDBs.
Been wanting to get rid of that for so long!
> On 64-bit systems this does not change the size of the scsi_cmnd at
> all, while on 32-bit systems it slightly increases it for now, but
> that increase will be made up by the removal of the remaining
> scsi_request fields.
Excellent!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-02-23 3:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 14:04 remove struct scsi_request Christoph Hellwig
2022-02-22 14:04 ` [PATCH 1/8] bsg: don't include scsi_request.h in bsg-lib.h Christoph Hellwig
2022-02-22 18:33 ` Bart Van Assche
2022-02-22 14:04 ` [PATCH 2/8] target/pscsi: remove struct pscsi_plugin_task Christoph Hellwig
2022-02-22 14:04 ` [PATCH 3/8] scsi: don't memset the entire scsi_cmnd in scsi_init_command Christoph Hellwig
2022-02-23 12:21 ` John Garry
2022-02-23 12:39 ` Christoph Hellwig
2022-02-23 12:56 ` John Garry
2022-02-23 12:58 ` Christoph Hellwig
2022-02-23 20:16 ` Bart Van Assche
2022-02-24 6:52 ` Christoph Hellwig
2022-02-23 23:03 ` Bart Van Assche
2022-02-24 8:28 ` John Garry
2022-02-24 16:27 ` Christoph Hellwig
2022-02-24 16:38 ` John Garry
2022-02-22 14:04 ` [PATCH 4/8] scsi: remove the cmd field from struct scsi_request Christoph Hellwig
2022-02-23 3:31 ` Martin K. Petersen [this message]
2022-02-23 23:36 ` Bart Van Assche
2022-02-22 14:04 ` [PATCH 5/8] scsi: remove the sense and sense_len fields " Christoph Hellwig
2022-02-23 23:39 ` Bart Van Assche
2022-02-24 6:53 ` Christoph Hellwig
2022-02-22 14:04 ` [PATCH 6/8] scsi: move the resid_len field from struct scsi_request to struct scsi_cmnd Christoph Hellwig
2022-02-23 23:41 ` Bart Van Assche
2022-02-22 14:04 ` [PATCH 7/8] scsi: move the result " Christoph Hellwig
2022-02-23 23:43 ` Bart Van Assche
2022-02-22 14:04 ` [PATCH 8/8] scsi: remove struct scsi_request Christoph Hellwig
2022-02-23 23:48 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1ley2b6rw.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.