From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8375AC33CAA for ; Tue, 21 Jan 2020 04:59:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55A1B24653 for ; Tue, 21 Jan 2020 04:59:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="JdRL/Czk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728205AbgAUE73 (ORCPT ); Mon, 20 Jan 2020 23:59:29 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:35946 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727829AbgAUE73 (ORCPT ); Mon, 20 Jan 2020 23:59:29 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00L4w2VP069447; Tue, 21 Jan 2020 04:59:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=8glou52mTpu5uP6vXtVh54NZS+K4n53hnH+7RouWk4U=; b=JdRL/CzkUZNRfn/18quf0x7cQIR1+zqEZ4UnCB0qFxWrIMik7XHOUm82BGL3CHMsEJ6c CBoInpfChjvXgrfdcB/IJdpaVjKa0uYvTPH34YY6d330G1fbLFQWXJPzphsSg7LvlDGJ nqHrKXNL3uvzfeoxHt3XRAw17VRYwa6rOmxdi6g+8Gxj3v4MGTTrEnMsuh/DIfyeTZq/ mOi1smkUGEEJ1hvG8E5AILkhvttFqCU2FA4MIafXgxo0MEn2OD6JtbP9N/Yasi8QvKax FTfowqghLrSwHx63tXhUqj5MPMh5h/TEXqmybhXakZQ80+CbJlDSqUm6SuIhgdfBYiWq cw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 2xksyq2f95-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Jan 2020 04:59:19 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00L4xFxK033485; Tue, 21 Jan 2020 04:59:19 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 2xnsj3tt9j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Jan 2020 04:59:18 +0000 Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 00L4wm54030711; Tue, 21 Jan 2020 04:58:49 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 20 Jan 2020 20:58:48 -0800 To: Hannes Reinecke Cc: Satish Kharat , Sesidhar Baddela , Karan Tilak Kumar , "Martin K. Petersen" , Christoph Hellwig , James Bottomley , linux-scsi@vger.kernel.org Subject: Re: [PATCH] fnic: do not queue commands during fwreset From: "Martin K. Petersen" Organization: Oracle Corporation References: <20200116102053.62755-1-hare@suse.de> Date: Mon, 20 Jan 2020 23:58:45 -0500 In-Reply-To: <20200116102053.62755-1-hare@suse.de> (Hannes Reinecke's message of "Thu, 16 Jan 2020 11:20:53 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9506 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=732 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001210043 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9506 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=795 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001210043 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Hannes, > When a link is going down the driver will be calling > fnic_cleanup_io(), which will traverse all commands and calling 'done' > for each found command. While the traversal is handled under the > host_lock, calling 'done' happens after the host_lock is being > dropped. Applied to 5.5/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering