All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bill Kuzeja <William.Kuzeja@stratus.com>
Cc: <linux-scsi@vger.kernel.org>, <qla2xxx-upstream@qlogic.com>
Subject: Re: [PATCH RESEND] qla2xxx: Fix gnl.l memory leak on adapter init failure
Date: Wed, 14 Aug 2019 21:51:26 -0400	[thread overview]
Message-ID: <yq1lfvv2o2p.fsf@oracle.com> (raw)
In-Reply-To: <1565792681-9641-1-git-send-email-William.Kuzeja@stratus.com> (Bill Kuzeja's message of "Wed, 14 Aug 2019 10:24:41 -0400")


Bill,

> If HBA initialization fails unexpectedly (exiting via probe_failed:),
> we may fail to free vha->gnl.l. So that we don't attempt to double
> free, set this pointer to NULL after a free and check for NULL at
> probe_failed: so we know whether or not to call dma_free_coherent.

Applied to 5.3/scsi-fixes, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

      parent reply	other threads:[~2019-08-15  1:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14 14:24 [PATCH RESEND] qla2xxx: Fix gnl.l memory leak on adapter init failure Bill Kuzeja
2019-08-14 17:37 ` Himanshu Madhani
2019-08-15  1:51 ` Martin K. Petersen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1lfvv2o2p.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=William.Kuzeja@stratus.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=qla2xxx-upstream@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.