From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Laurence Oberman <loberman@redhat.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: sd: Implement blacklist option for WRITE SAME w/ UNMAP
Date: Fri, 29 Sep 2017 09:21:48 -0400 [thread overview]
Message-ID: <yq1lgkx63o3.fsf@oracle.com> (raw)
In-Reply-To: <1506679376.11960.1.camel@redhat.com> (Laurence Oberman's message of "Fri, 29 Sep 2017 06:02:56 -0400")
Laurence,
> I am testing this but its not being picked up so I want to know if I
> have the kernel command line wrong here.
>
> scsi_dev_flags=LIO-ORG:thin2:0x80000000
>
> What am I doing wrong to pass the BLIST flags.
This worked for me:
[root@kvm ~]# echo "Linux:scsi_debug:0x80000000" > /proc/scsi/device_info
[root@kvm ~]# grep Linux /proc/scsi/device_info
'Linux ' 'scsi_debug ' 0x80000000
[root@kvm ~]# modprobe scsi_debug unmap_max_blocks=10 unmap_max_desc=1 write_same_length=20 lbpws=1
[root@kvm ~]# lsblk -D
NAME DISC-ALN DISC-GRAN DISC-MAX DISC-ZERO
sda 0 512B 5K 0
(With the caveat that I tweaked scsi_debug to report the UNMAP
parameters despite lbpu being 0).
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-09-29 13:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 16:14 [PATCH] sd: Limit WRITE SAME / WRITE SAME(16) w/UNMAP length for certain devices Ewan D. Milne
2017-09-19 17:32 ` Kuzeja, William
2017-09-26 1:46 ` Martin K. Petersen
2017-09-27 16:27 ` Ewan D. Milne
2017-09-27 16:42 ` Knight, Frederick
2017-09-28 1:34 ` Martin K. Petersen
2017-09-28 1:35 ` [PATCH] scsi: sd: Implement blacklist option for WRITE SAME w/ UNMAP Martin K. Petersen
2017-09-28 15:46 ` Ewan D. Milne
2017-09-29 10:02 ` Laurence Oberman
2017-09-29 13:21 ` Martin K. Petersen [this message]
2017-09-29 14:01 ` Laurence Oberman
2017-10-17 14:26 ` Laurence Oberman
2017-10-17 14:43 ` Laurence Oberman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1lgkx63o3.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.