From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: qla2xxx-upstream@qlogic.com,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Quinn Tran <quinn.tran@cavium.com>,
Himanshu Madhani <himanshu.madhani@cavium.com>,
Nicholas Bellinger <nab@linux-iscsi.org>,
Darren Trapp <darren.trapp@cavium.com>,
Anil Gurumurthy <anil.gurumurhty@cavium.com>,
Duane Grigsby <duane.grigsby@cavium.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] scsi: qla2xxx: avoid unused-function warning
Date: Sat, 01 Jul 2017 17:15:33 -0400 [thread overview]
Message-ID: <yq1lgo7voy2.fsf@oracle.com> (raw)
In-Reply-To: <20170630161056.30630-2-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 30 Jun 2017 18:10:40 +0200")
Arnd,
> When NVMe support is disabled, we get a couple of harmless warnings:
>
> drivers/scsi/qla2xxx/qla_nvme.c:667:13: error: 'qla_nvme_unregister_remote_port' defined but not used [-Werror=unused-function]
> drivers/scsi/qla2xxx/qla_nvme.c:634:13: error: 'qla_nvme_abort_all' defined but not used [-Werror=unused-function]
> drivers/scsi/qla2xxx/qla_nvme.c:604:12: error: 'qla_nvme_wait_on_rport_del' defined but not used [-Werror=unused-function]
>
> This replaces the preprocessor checks in the code with equivalent
> compiler conditionals, which lets gcc drop the unused functions
> without warning, and is nicer to read.
Applied to 4.13/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-07-01 21:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 16:10 [PATCH 1/2] scsi: qla2xxx: remove incorrect byte swap Arnd Bergmann
2017-06-30 16:10 ` [PATCH 2/2] scsi: qla2xxx: avoid unused-function warning Arnd Bergmann
2017-06-30 23:54 ` Madhani, Himanshu
2017-07-01 21:15 ` Martin K. Petersen [this message]
2017-06-30 16:41 ` [PATCH 1/2] scsi: qla2xxx: remove incorrect byte swap James Bottomley
2017-06-30 17:00 ` Madhani, Himanshu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1lgo7voy2.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=anil.gurumurhty@cavium.com \
--cc=arnd@arndb.de \
--cc=darren.trapp@cavium.com \
--cc=duane.grigsby@cavium.com \
--cc=himanshu.madhani@cavium.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=qla2xxx-upstream@qlogic.com \
--cc=quinn.tran@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.