From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Eric Biggers <ebiggers@kernel.org>
Subject: Re: [PATCH v2 0/2] Fix bio splitting in the crypto fallback code
Date: Mon, 14 Jul 2025 22:05:20 -0400 [thread overview]
Message-ID: <yq1ms965hvf.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20250711171853.68596-1-bvanassche@acm.org> (Bart Van Assche's message of "Fri, 11 Jul 2025 10:18:50 -0700")
Bart,
> When using the crypto fallback code, large bios are split twice. A
> first time by bio_split_to_limits() and a second time by the crypto
> fallback code. This causes bios not to be submitted in LBA error and
> hence triggers write errors for zoned block devices. This patch series
> fixes this by splitting bios once. Please consider this patch series
> for the next merge window.
Looks OK to me.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen
prev parent reply other threads:[~2025-07-15 2:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 17:18 [PATCH v2 0/2] Fix bio splitting in the crypto fallback code Bart Van Assche
2025-07-11 17:18 ` [PATCH v2 1/2] block: Split blk_crypto_fallback_split_bio_if_needed() Bart Van Assche
2025-07-14 11:29 ` Christoph Hellwig
2025-07-14 13:48 ` John Garry
2025-07-14 15:35 ` Bart Van Assche
2025-07-15 5:40 ` Christoph Hellwig
2025-07-11 17:18 ` [PATCH v2 2/2] block: Rework splitting of encrypted bios Bart Van Assche
2025-07-15 2:18 ` Eric Biggers
2025-07-15 5:37 ` Christoph Hellwig
2025-07-15 6:11 ` Eric Biggers
2025-07-15 6:21 ` Christoph Hellwig
2025-07-16 1:39 ` Damien Le Moal
2025-07-15 5:44 ` Christoph Hellwig
2025-07-14 11:35 ` [PATCH v2 0/2] Fix bio splitting in the crypto fallback code Christoph Hellwig
2025-07-14 15:37 ` Bart Van Assche
2025-07-15 2:05 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1ms965hvf.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=ebiggers@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.