From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Thierry Escande <thierry.escande@collabora.com>,
Bart Van Assche <Bart.VanAssche@sandisk.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sd: Ignore sync cache failures when not supported
Date: Mon, 08 May 2017 21:55:41 -0400 [thread overview]
Message-ID: <yq1mvamssiq.fsf@oracle.com> (raw)
In-Reply-To: <20170505090201.GA31209@infradead.org> (Christoph Hellwig's message of "Fri, 5 May 2017 02:02:01 -0700")
Christoph,
> Normally we'd just pass the scsi_sense_hdr structure in from the caler
> if we care about sense data. Is this something you considered?
>
> Otherwise this looks fine to me.
I agree with Christoph that passing the sense header would be more
consistent with the rest of the SCSI code. Even if we only need the key
in this case.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-05-09 1:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 9:43 [PATCH v2] sd: Ignore sync cache failures when not supported Thierry Escande
2017-05-04 15:19 ` Bart Van Assche
2017-05-05 9:02 ` Christoph Hellwig
2017-05-05 11:46 ` Thierry Escande
2017-05-09 1:55 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1mvamssiq.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=hch@infradead.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=thierry.escande@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.