From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@infradead.org>, Shaohua Li <shli@fb.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
sitsofe@yahoo.com, axboe@fb.com, Kernel-team@fb.com
Subject: Re: block: correctly fallback for zeroout
Date: Mon, 06 Jun 2016 22:32:38 -0400 [thread overview]
Message-ID: <yq1mvmxohix.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20160603035415.GA8236@redhat.com> (Mike Snitzer's message of "Thu, 2 Jun 2016 23:54:15 -0400")
>>>>> "Mike" == Mike Snitzer <snitzer@redhat.com> writes:
Mike> But hch was originally in favor of _always_ dropping EOPNOTSUPP on
Mike> the floor (that is what his commit 38f25255330 did). Then he said
Mike> he disagrees with these interfaces playing games with masking
Mike> EOPNOTSUPP -- to which you seemingly really don't agree. Unless
Mike> I'm completely misreading you.
Userland apps rely on EOPNOTSUPP, we can't break that.
What I don't like this is "soft" error special casing of EOPNOTSUPP in
the actual implementation of discard, write same, etc. These functions
should return either success or failure. And the ioctl wrapper should
then decide whether to return EOPNOTSUPP, EIO or EPONIES.
I.e. separate the policy from the implementation. This would also solve
some of the grievances for the target folks.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2016-06-07 2:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 18:08 [PATCH] block: correctly fallback for zeroout Shaohua Li
2016-05-29 6:47 ` Christoph Hellwig
2016-06-03 3:06 ` Martin K. Petersen
2016-06-03 3:54 ` Mike Snitzer
2016-06-07 2:32 ` Martin K. Petersen [this message]
2016-06-07 6:38 ` Christoph Hellwig
2016-06-10 2:05 ` Martin K. Petersen
[not found] ` <20160527054918.GA9521@sucs.org>
2016-05-28 9:27 ` [PATCH] " Sitsofe Wheeler
2016-05-28 9:27 ` Sitsofe Wheeler
2016-06-02 16:58 ` Shaohua Li
2016-06-02 17:02 ` Martin K. Petersen
2016-06-03 2:56 ` Martin K. Petersen
2016-06-03 3:26 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1mvmxohix.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=Kernel-team@fb.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@fb.com \
--cc=sitsofe@yahoo.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.