From: "Martin K. Petersen" <mkp@kernel.org>
To: Daniel Wagner <dwagner@suse.de>
Cc: Nilesh Javali <njavali@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com,
"Martin K. Petersen" <mkp@kernel.org>,
Himanshu Madhani <himanshu.madhani@oracle.com>,
Quinn Tran <qutran@marvell.com>,
linux-scsi@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 0/7] scsi: qla2xxx: Fix races, leaks and inverted logic found in review
Date: Fri, 20 Nov 2026 21:32:35 -0500 [thread overview]
Message-ID: <yq1o6bior7r.fsf@mail.kernel.org> (raw)
In-Reply-To: <20261103-qla2xxx-fix-v2-0-c6d2cdf2c806@suse.de>
Daniel,
> A review of recent qla2xxx changes turned up a handful of bugs in
> commits that are already upstream and partly marked for stable:
Found two regressions:
1. **Patch 3:** SRB address reuse can let the timeout handler remove and
free another BSG job’s command. Retain the job-identity check alongside
the pointer comparison.
2. **Patch 5:** ISP82xx recovery can skip `slot_reset()`, leaving
`IRQ_NO_BALANCING` set after successful recovery.
--
Martin K. Petersen
prev parent reply other threads:[~2026-11-21 2:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 12:31 [PATCH v2 0/7] scsi: qla2xxx: Fix races, leaks and inverted logic found in review Daniel Wagner
2026-11-03 12:31 ` [PATCH v2 1/7] scsi: qla2xxx: Check FCE state under fce_mutex in debugfs release Daniel Wagner
2026-11-03 12:31 ` [PATCH v2 2/7] scsi: qla2xxx: Don't clear SF_SCANNING of a running fabric scan Daniel Wagner
2026-11-03 12:31 ` [PATCH v2 3/7] scsi: qla2xxx: Fix use-after-free on late bsg completion Daniel Wagner
2026-11-03 12:31 ` [PATCH v2 4/7] scsi: qla2xxx: target: Fix cmd release on CDB allocation failure Daniel Wagner
2026-11-03 12:31 ` [PATCH v2 5/7] scsi: qla2xxx: Fix inverted IRQ_NO_BALANCING toggling around PCI reset Daniel Wagner
2026-11-03 12:31 ` [PATCH v2 6/7] scsi: qla2xxx: Reject unsolicited NVMe LS from ports without NVMe rport Daniel Wagner
2026-11-03 12:31 ` [PATCH v2 7/7] scsi: qla2xxx: Use FC_SPEED_2 to check for the 64G SFP speed byte Daniel Wagner
2026-11-21 2:32 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1o6bior7r.fsf@mail.kernel.org \
--to=mkp@kernel.org \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=dwagner@suse.de \
--cc=himanshu.madhani@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=njavali@marvell.com \
--cc=qutran@marvell.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.