From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Juergen Gross <jgross@suse.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
Stefano Stabellini <sstabellini@kernel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
xen-devel@lists.xenproject.org,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH] xen/scsifront: shost_priv() can never return NULL
Date: Thu, 24 Aug 2023 22:07:15 -0400 [thread overview]
Message-ID: <yq1o7iv3mf9.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20230822064817.27257-1-jgross@suse.com> (Juergen Gross's message of "Tue, 22 Aug 2023 08:48:17 +0200")
Juergen,
> There is no need to check whether shost_priv() returns a non-NULL
> value, as the pointer returned is just an offset to the passed in
> parameter.
>
> While at it replace an open coded shost_priv() instance.
Applied to 6.6/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2023-08-25 2:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 6:48 [PATCH] xen/scsifront: shost_priv() can never return NULL Juergen Gross
2023-08-25 2:07 ` Martin K. Petersen [this message]
2023-08-31 1:48 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1o7iv3mf9.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=dan.carpenter@linaro.org \
--cc=jejb@linux.ibm.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.