From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jaesoo Lee <jalee@purestorage.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jens Axboe <axboe@kernel.dk>,
Douglas Gilbert <dgilbert@interlog.com>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
Roland Dreier <roland@purestorage.com>
Subject: Re: [PATCHv2] scsi: core: set result when the command cannot be dispatched
Date: Mon, 15 Apr 2019 22:36:27 -0400 [thread overview]
Message-ID: <yq1o956fzh0.fsf@oracle.com> (raw)
In-Reply-To: <CAJX3CtgE5oN=uw2rAWS8hsqkEZHCgfy5r=McFTj0rhRd490HhQ@mail.gmail.com> (Jaesoo Lee's message of "Tue, 9 Apr 2019 17:02:22 -0700")
Jaesoo,
> When SCSI blk-mq is enabled, there is a bug in handling errors in
> scsi_queue_rq. Specifically, the bug is not setting result field of
> scsi_request correctly when the dispatch of the command has been
> failed. Since the upper layer code including the sg_io ioctl expects
> to receive any error status from result field of scsi_request, the
> error is silently ignored and this could cause data corruptions for
> some applications.
Applied to 5.1/scsi-fixes, thank you!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2019-04-16 2:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1554854375-7708-1-git-send-email-jalee@purestorage.com>
2019-04-10 0:02 ` [PATCHv2] scsi: core: set result when the command cannot be dispatched Jaesoo Lee
2019-04-10 5:58 ` Hannes Reinecke
2019-04-10 16:26 ` Bart Van Assche
2019-04-16 2:36 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1o956fzh0.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dgilbert@interlog.com \
--cc=jalee@purestorage.com \
--cc=jejb@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.