From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size Date: Wed, 29 Jun 2016 00:58:06 -0400 Message-ID: References: <146612624734.12764.4316680863289411106.stgit@birch.djwong.org> <146612626092.12764.773833541076937471.stgit@birch.djwong.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <146612626092.12764.773833541076937471.stgit@birch.djwong.org> (Darrick J. Wong's message of "Thu, 16 Jun 2016 18:17:41 -0700") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: "Darrick J. Wong" Cc: axboe@kernel.dk, linux-block@vger.kernel.org, tytso@mit.edu, martin.petersen@oracle.com, snitzer@redhat.com, linux-api@vger.kernel.org, bfoster@redhat.com, xfs@oss.sgi.com, hch@infradead.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, Christoph Hellwig List-Id: dm-devel.ids >>>>> "Darrick" == Darrick J Wong writes: Darrick> Make sure that the offset and length arguments that we're using Darrick> to construct WRITE SAME and DISCARD requests are actually Darrick> aligned to the logical block size. Failure to do this causes Darrick> other errors in other parts of the block layer or the SCSI Darrick> layer because disks don't support partial logical block writes. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: To: "Darrick J. Wong" Cc: axboe@kernel.dk, hch@infradead.org, tytso@mit.edu, martin.petersen@oracle.com, snitzer@redhat.com, linux-api@vger.kernel.org, bfoster@redhat.com, xfs@oss.sgi.com, linux-block@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size From: "Martin K. Petersen" References: <146612624734.12764.4316680863289411106.stgit@birch.djwong.org> <146612626092.12764.773833541076937471.stgit@birch.djwong.org> Date: Wed, 29 Jun 2016 00:58:06 -0400 In-Reply-To: <146612626092.12764.773833541076937471.stgit@birch.djwong.org> (Darrick J. Wong's message of "Thu, 16 Jun 2016 18:17:41 -0700") Message-ID: MIME-Version: 1.0 Content-Type: text/plain List-ID: >>>>> "Darrick" == Darrick J Wong writes: Darrick> Make sure that the offset and length arguments that we're using Darrick> to construct WRITE SAME and DISCARD requests are actually Darrick> aligned to the logical block size. Failure to do this causes Darrick> other errors in other parts of the block layer or the SCSI Darrick> layer because disks don't support partial logical block writes. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering