All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Kent Overstreet <kmo@daterainc.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Hugh Dickins <hughd@google.com>, Jens Axboe <axboe@kernel.dk>,
	Shaohua Li <shli@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: next bio iters break discard?
Date: Tue, 14 Jan 2014 15:17:32 -0500	[thread overview]
Message-ID: <yq1ob3el3mr.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20140114044841.GO9037@kmo> (Kent Overstreet's message of "Mon, 13 Jan 2014 20:48:41 -0800")

>>>>> "Kent" == Kent Overstreet <kmo@daterainc.com> writes:

>> IOW, DISCARD, WRITE SAME and the impending COPY requests do not have
>> a 1:1 mapping between the block range worked on and the size of any
>> bvecs attached. Your recent changes must have changed the way we
>> handled that in the past.

Kent> Yeah - but with WRITE_SAME bios, wouldn't we at least have to
Kent> check that they're writing the same data to merge them?

We do. Check blk_write_same_mergeable().

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2014-01-14 20:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-13  3:52 next bio iters break discard? Hugh Dickins
2014-01-14  2:33 ` Kent Overstreet
2014-01-14  4:06   ` Martin K. Petersen
2014-01-14  4:48     ` Kent Overstreet
2014-01-14 20:17       ` Martin K. Petersen [this message]
2014-01-14 22:24         ` Kent Overstreet
2014-01-16  1:39           ` Martin K. Petersen
2014-01-16 20:21           ` Hugh Dickins
2014-01-17  1:06             ` Kent Overstreet
2014-01-17  1:21             ` Kent Overstreet
2014-01-31 17:17               ` Hugh Dickins
2014-01-31 21:58                 ` Jens Axboe
2014-02-04 10:17                 ` [PATCH] block: Explicitly handle discard/write same segments Kent Overstreet
2014-02-04 12:25                   ` Hugh Dickins
2014-02-04 12:35                     ` Kent Overstreet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1ob3el3mr.fsf@sermon.lab.mkp.net \
    --to=martin.petersen@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=hughd@google.com \
    --cc=kmo@daterainc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shli@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.