From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Mike Snitzer <snitzer@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>, Song Liu <song@kernel.org>,
Yu Kuai <yukuai3@huawei.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Kanchan Joshi <joshi.k@samsung.com>,
linux-block@vger.kernel.org, dm-devel@lists.linux.dev,
linux-raid@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH 3/3] block: split struct bio_integrity_data
Date: Mon, 03 Feb 2025 14:45:42 -0500 [thread overview]
Message-ID: <yq1pljyizht.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20250131122436.1317268-4-hch@lst.de> (Christoph Hellwig's message of "Fri, 31 Jan 2025 13:24:18 +0100")
Christoph,
> Many of the fields in struct bio_integrity_data are only needed for
> the default integrity buffer in the block layer, and the variable
> sized array at the end of the structure makes it very hard to embed
> into caller allocated structures.
This looks OK to me.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2025-02-03 19:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 12:24 RFC: split out the auto-PI code and data structures Christoph Hellwig
2025-01-31 12:24 ` [PATCH 1/3] block: mark bounce buffering as incompatible with integrity Christoph Hellwig
2025-01-31 16:54 ` Bart Van Assche
2025-02-03 19:33 ` Martin K. Petersen
2025-01-31 12:24 ` [PATCH 2/3] block: move the block layer auto-integrity code into a new file Christoph Hellwig
2025-02-03 19:41 ` Martin K. Petersen
2025-02-04 5:45 ` Christoph Hellwig
2025-01-31 12:24 ` [PATCH 3/3] block: split struct bio_integrity_data Christoph Hellwig
2025-02-03 19:45 ` Martin K. Petersen [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-02-18 18:21 split out the auto-PI code and data structures Christoph Hellwig
2025-02-18 18:21 ` [PATCH 3/3] block: split struct bio_integrity_data Christoph Hellwig
2025-02-19 11:34 ` Kanchan Joshi
2025-02-19 16:40 ` Hannes Reinecke
2025-02-21 6:07 ` Anuj gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1pljyizht.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@lists.linux.dev \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.