All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: Christoph Hellwig <hch@lst.de>, Anuj Gupta <anuj20.g@samsung.com>,
	axboe@kernel.dk, kbusch@kernel.org, martin.petersen@oracle.com,
	asml.silence@gmail.com, krisman@suse.de,
	io-uring@vger.kernel.org, linux-nvme@lists.infradead.org,
	linux-block@vger.kernel.org, gost.dev@samsung.com,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH v3 07/10] block: introduce BIP_CHECK_GUARD/REFTAG/APPTAG bip_flags
Date: Wed, 28 Aug 2024 23:16:53 -0400	[thread overview]
Message-ID: <yq1plpsauu5.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <fe85a641-c974-3fa7-43f1-eacbb7834210@samsung.com> (Kanchan Joshi's message of "Wed, 28 Aug 2024 19:12:22 +0530")


Kanchan,

> With Guard/Reftag/Apptag, we get 6 combinations. For NVMe, all can be
> valid. For SCSI, maximum 4 can be valid. And we factor the pi-type in
> while listing what all is valid. For example: 010 or 001 is not valid
> for SCSI and should not be shown by this.

I thought we had tentatively agreed to let the block layer integrity
flags only describe what the controller should do? And then let sd.c
decide what to do about RDPROTECT/WRPROTECT (since host-to-target is a
different protection envelope anyway). That is kind of how it works
already.

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2024-08-29  3:17 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240823104552epcas5p226dbbbd448cd0ee0955ffdd3ad1b112d@epcas5p2.samsung.com>
2024-08-23 10:38 ` [PATCH v3 00/10] Read/Write with meta/integrity Anuj Gupta
2024-08-23 10:38   ` [PATCH v3 01/10] block: define set of integrity flags to be inherited by cloned bip Anuj Gupta
2024-08-24  8:24     ` Christoph Hellwig
2024-08-29  3:05     ` Martin K. Petersen
2024-08-23 10:38   ` [PATCH v3 02/10] block: introduce a helper to determine metadata bytes from data iter Anuj Gupta
2024-08-24  8:24     ` Christoph Hellwig
2024-08-29  3:06     ` Martin K. Petersen
2024-08-23 10:38   ` [PATCH v3 03/10] block: handle split correctly for user meta bounce buffer Anuj Gupta
2024-08-24  8:31     ` Christoph Hellwig
2024-08-28 11:18       ` Anuj Gupta
2024-08-29  4:04         ` Christoph Hellwig
2024-08-23 10:38   ` [PATCH v3 04/10] block: modify bio_integrity_map_user to accept iov_iter as argument Anuj Gupta
2024-08-23 10:38   ` [PATCH v3 05/10] block: define meta io descriptor Anuj Gupta
2024-08-24  8:31     ` Christoph Hellwig
2024-08-29  3:05     ` Martin K. Petersen
2024-08-23 10:38   ` [PATCH v3 06/10] io_uring/rw: add support to send meta along with read/write Anuj Gupta
2024-08-24  8:33     ` Christoph Hellwig
2024-08-23 10:38   ` [PATCH v3 07/10] block: introduce BIP_CHECK_GUARD/REFTAG/APPTAG bip_flags Anuj Gupta
2024-08-24  8:35     ` Christoph Hellwig
2024-08-28 13:42       ` Kanchan Joshi
2024-08-29  3:16         ` Martin K. Petersen [this message]
2024-08-29  4:06           ` Christoph Hellwig
2024-08-29 13:29           ` Anuj gupta
2024-09-12 12:40             ` Anuj Gupta
2024-09-13  2:06             ` Martin K. Petersen
2024-08-29  4:06         ` Christoph Hellwig
2024-08-23 10:38   ` [PATCH v3 07/10] block,nvme: " Anuj Gupta
2024-08-23 10:38   ` [PATCH v3 08/10] block: add support to pass user meta buffer Anuj Gupta
2024-08-24  8:44     ` Christoph Hellwig
2024-08-23 10:38   ` [PATCH v3 09/10] nvme: add handling for app_tag Anuj Gupta
2024-08-24  8:49     ` Christoph Hellwig
2024-08-29  3:00     ` Martin K. Petersen
2024-08-29 10:18       ` Kanchan Joshi
2024-09-13  2:05         ` Martin K. Petersen
2024-08-23 10:38   ` [PATCH v3 10/10] scsi: add support for user-meta interface Anuj Gupta
2024-08-24  8:52     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1plpsauu5.fsf@ca-mkp.ca.oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=anuj20.g@samsung.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=gost.dev@samsung.com \
    --cc=hch@lst.de \
    --cc=io-uring@vger.kernel.org \
    --cc=joshi.k@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=krisman@suse.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.