From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Chris Bainbridge <chris.bainbridge@gmail.com>,
"fengli@smartx.com" <fengli@smartx.com>, hch <hch@lst.de>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [REGRESSION] critical target error, bisected
Date: Fri, 16 Aug 2024 20:51:36 -0400 [thread overview]
Message-ID: <yq1plq8otwh.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <whnt3t5fqae5pujt6fkg5xu6mqxc2x5llbmq6q2lclfuuafbqx@tzj3dzgb7ury> (Shinichiro Kawasaki's message of "Fri, 16 Aug 2024 07:59:52 +0000")
Shinichiro,
> I guess SD_LBP_FULL would be more appropriate than SD_LBP_DISABLE,
> because the comment in drivers/scsi/sd.h says that SD_LBP_DISABLE
> indicates that "Discard disabled due to failed cmd".
> I confirmed that the fix patch avoids my failure both with
> SD_LBP_DISABLE and SD_LBP_FULL.
Yes, you are right. It is more appropriate to print "full" in sysfs when
LBMPE is disabled. Printing aside, the two modes are identical. I
switched the return to SDP_LBP_FULL.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2024-08-17 0:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 14:49 [REGRESSION] critical target error, bisected Chris Bainbridge
2024-08-12 15:21 ` Fwd: " Chris Bainbridge
2024-08-13 2:09 ` Martin K. Petersen
2024-08-13 2:21 ` Martin K. Petersen
2024-08-16 3:56 ` Martin K. Petersen
2024-08-16 6:08 ` Chris Bainbridge
2024-08-16 7:59 ` Shinichiro Kawasaki
2024-08-16 8:06 ` hch
2024-08-17 0:51 ` Martin K. Petersen [this message]
2024-08-16 8:21 ` John Garry
2024-08-17 0:53 ` [PATCH] scsi: sd: Do not attempt to configure discard unless LBPME is set Martin K. Petersen
2024-08-17 1:28 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1plq8otwh.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=chris.bainbridge@gmail.com \
--cc=fengli@smartx.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.