From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
Luo Jiaxing <luojiaxing@huawei.com>,
John Garry <john.garry@huawei.com>
Subject: Re: [PATCH] enclosure: Fix stale device oops with hot replug
Date: Fri, 10 Jan 2020 01:39:55 -0500 [thread overview]
Message-ID: <yq1pnfrvmpw.fsf@oracle.com> (raw)
In-Reply-To: <1578532892.3852.10.camel@HansenPartnership.com> (James Bottomley's message of "Wed, 08 Jan 2020 17:21:32 -0800")
James,
> Doing an add/remove/add on a SCSI device in an enclosure leads to an
> oops caused by poisoned values in the enclosure device list pointers.
> The reason is because we are keeping the enclosure device across the
> enclosed device add/remove/add but the current code is doing a
> device_add/device_del/device_add on it. This is the wrong thing to do
> in sysfs, so fix it by not doing a device_del on the enclosure device
> simply because of a hot remove of the drive in the slot.
Applied to 5.5/scsi-fixes...
> Fixes: 43d8eb9cfd0a ("[SCSI] ses: add support for enclosure component hot removal")
> Reported-by: Luo Jiaxing
> Tested-by: John Garry
> Signed-off-by: James Bottomley
...and filled out the blanks.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2020-01-10 6:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 1:21 [PATCH] enclosure: Fix stale device oops with hot replug James Bottomley
2020-01-10 6:39 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1pnfrvmpw.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=john.garry@huawei.com \
--cc=linux-scsi@vger.kernel.org \
--cc=luojiaxing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.