From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Date: Wed, 10 Jan 2018 21:50:53 +0000 Subject: Re: [PATCH][scsi-next] scsi: qla2xxx: remove redundant assignment of d Message-Id: List-Id: References: <20180105155037.17981-1-colin.king@canonical.com> In-Reply-To: <20180105155037.17981-1-colin.king@canonical.com> (Colin King's message of "Fri, 5 Jan 2018 15:50:37 +0000") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: qla2xxx-upstream@qlogic.com, "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Colin, > The initialization of d is redundant as this value is never read > and it is overwritten inside the subsequent for-loop. Remove this > redundant assignment. Applied to 4.16/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH][scsi-next] scsi: qla2xxx: remove redundant assignment of d Date: Wed, 10 Jan 2018 16:50:53 -0500 Message-ID: References: <20180105155037.17981-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20180105155037.17981-1-colin.king@canonical.com> (Colin King's message of "Fri, 5 Jan 2018 15:50:37 +0000") Sender: linux-kernel-owner@vger.kernel.org To: Colin King Cc: qla2xxx-upstream@qlogic.com, "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org Colin, > The initialization of d is redundant as this value is never read > and it is overwritten inside the subsequent for-loop. Remove this > redundant assignment. Applied to 4.16/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering