From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Date: Tue, 13 Jun 2017 01:05:29 +0000 Subject: Re: [PATCH] scsi: lpfc: make a couple of functions static Message-Id: List-Id: References: <20170518093524.13549-1-colin.king@canonical.com> In-Reply-To: <20170518093524.13549-1-colin.king@canonical.com> (Colin King's message of "Thu, 18 May 2017 10:35:24 +0100") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: James Smart , Dick Kennedy , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Colin, > functions lpfc_nvmet_cleanup_io_context and > lpfc_nvmet_setup_io_context can be made static as they do not need to > be in global scope. > > Cleans up sparse warnings: > "warning: symbol 'lpfc_nvmet_cleanup_io_context' was not declared. > Should it be static?" > "warning: symbol 'lpfc_nvmet_setup_io_context' was not declared. > Should it be static?" Applied to 4.13/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH] scsi: lpfc: make a couple of functions static Date: Mon, 12 Jun 2017 21:05:29 -0400 Message-ID: References: <20170518093524.13549-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:33374 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753100AbdFMBFm (ORCPT ); Mon, 12 Jun 2017 21:05:42 -0400 In-Reply-To: <20170518093524.13549-1-colin.king@canonical.com> (Colin King's message of "Thu, 18 May 2017 10:35:24 +0100") Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Colin King Cc: James Smart , Dick Kennedy , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Colin, > functions lpfc_nvmet_cleanup_io_context and > lpfc_nvmet_setup_io_context can be made static as they do not need to > be in global scope. > > Cleans up sparse warnings: > "warning: symbol 'lpfc_nvmet_cleanup_io_context' was not declared. > Should it be static?" > "warning: symbol 'lpfc_nvmet_setup_io_context' was not declared. > Should it be static?" Applied to 4.13/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering