All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Anuj Gupta <anuj20.g@samsung.com>
Cc: axboe@kernel.dk, hch@lst.de, kbusch@kernel.org,
	martin.petersen@oracle.com, asml.silence@gmail.com,
	anuj1072538@gmail.com, brauner@kernel.org, jack@suse.cz,
	viro@zeniv.linux.org.uk, io-uring@vger.kernel.org,
	linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
	gost.dev@samsung.com, linux-scsi@vger.kernel.org,
	vishak.g@samsung.com, linux-fsdevel@vger.kernel.org,
	Kanchan Joshi <joshi.k@samsung.com>
Subject: Re: [PATCH v11 06/10] io_uring: introduce attributes for read/write and PI support
Date: Mon, 02 Dec 2024 21:13:14 -0500	[thread overview]
Message-ID: <yq1r06psey3.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20241128112240.8867-7-anuj20.g@samsung.com> (Anuj Gupta's message of "Thu, 28 Nov 2024 16:52:36 +0530")


Anuj,

> Add the ability to pass additional attributes along with read/write.
> Application can prepare attibute specific information and pass its
> address using the SQE field:
> 	__u64	attr_ptr;
>
> Along with setting a mask indicating attributes being passed:
> 	__u64	attr_type_mask;
>
> Overall 64 attributes are allowed and currently one attribute
> 'IORING_RW_ATTR_FLAG_PI' is supported.

I have things running on my end on top of Jens' tree (without error
injection, that's to come).

One question, though: How am I to determine that the kernel supports
attr_ptr and IORING_RW_ATTR_FLAG_PI? Now that we no longer have separate
IORING_OP_{READ,WRITE}_META commands I can't use IO_URING_OP_SUPPORTED
to find out whether the running kernel supports PI passthrough.

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2024-12-03  2:13 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20241128113036epcas5p397ba228852b72fff671fe695c322a3ef@epcas5p3.samsung.com>
2024-11-28 11:22 ` [PATCH v11 00/10] Read/Write with meta/integrity Anuj Gupta
2024-11-28 11:22   ` [PATCH v11 01/10] block: define set of integrity flags to be inherited by cloned bip Anuj Gupta
2024-11-28 11:22   ` [PATCH v11 02/10] block: copy back bounce buffer to user-space correctly in case of split Anuj Gupta
2024-11-28 11:22   ` [PATCH v11 03/10] block: modify bio_integrity_map_user to accept iov_iter as argument Anuj Gupta
2024-11-28 11:22   ` [PATCH v11 04/10] fs, iov_iter: define meta io descriptor Anuj Gupta
2024-11-28 11:22   ` [PATCH v11 05/10] fs: introduce IOCB_HAS_METADATA for metadata Anuj Gupta
2024-11-28 11:22   ` [PATCH v11 06/10] io_uring: introduce attributes for read/write and PI support Anuj Gupta
2024-12-03  2:13     ` Martin K. Petersen [this message]
2024-12-03  6:56       ` Anuj Gupta
2024-12-03 12:00         ` Pavel Begunkov
2024-12-04  8:09           ` Anuj Gupta
2024-12-05 18:04     ` Keith Busch
2024-12-05 20:17       ` Martin K. Petersen
2024-12-06 12:07       ` Pavel Begunkov
2024-11-28 11:22   ` [PATCH v11 07/10] block: introduce BIP_CHECK_GUARD/REFTAG/APPTAG bip_flags Anuj Gupta
2025-02-03  6:53     ` Christoph Hellwig
2025-02-03 14:39       ` Anuj Gupta
2025-02-04  5:39         ` Christoph Hellwig
2025-02-05 11:51           ` Anuj Gupta
2025-02-05 15:42             ` Christoph Hellwig
2024-11-28 11:22   ` [PATCH v11 08/10] nvme: add support for passing on the application tag Anuj Gupta
2024-11-28 11:22   ` [PATCH v11 09/10] scsi: add support for user-meta interface Anuj Gupta
2024-11-28 11:22   ` [PATCH v11 10/10] block: add support to pass user meta buffer Anuj Gupta
2024-11-29 16:04   ` [PATCH v11 00/10] Read/Write with meta/integrity Jens Axboe
2025-06-04  6:39   ` Christoph Hellwig
2025-06-04  7:15     ` Anuj gupta
2025-06-04  7:30       ` Christoph Hellwig
2025-06-04 19:53     ` Daniel Gomez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1r06psey3.fsf@ca-mkp.ca.oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=anuj1072538@gmail.com \
    --cc=anuj20.g@samsung.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=brauner@kernel.org \
    --cc=gost.dev@samsung.com \
    --cc=hch@lst.de \
    --cc=io-uring@vger.kernel.org \
    --cc=jack@suse.cz \
    --cc=joshi.k@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=vishak.g@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.