From: martin.petersen@oracle.com (Martin K. Petersen)
Subject: [PATCH] nvme-core: add support for Write-Zeroes command
Date: Tue, 18 Dec 2018 22:34:02 -0500 [thread overview]
Message-ID: <yq1r2eei40l.fsf@oracle.com> (raw)
In-Reply-To: <20181218034203.22256-1-chaitanya.kulkarni@wdc.com> (Chaitanya Kulkarni's message of "Mon, 17 Dec 2018 22:42:03 -0500")
Chaitanya,
> Allow write zeroes operations (REQ_OP_WRITE_ZEROES) on the block
> device, if the device supports an optional command bit set for write
> zeroes. Add support to setup write zeroes command. Set maximum
> possible write zeroes sectors in one write zeroes command according to
> nvme write zeroes command definition.
>
> This patch was posted as a part of block-write-zeroes support
> implementation (https://patchwork.kernel.org/patch/9454859/), but did
> not make into mainline kernel as it got reverted due to failure on the
> Linus's machine.
>
> In this patch in order to be more cautious, we use NVMe controller's
> maximum hardware sector size which is calculated based on the
> controller's MDTS (Maximum Data Transfer Size) field to calculate the
> maximum sectors for the write zeroes request.
Looks good to me.
Reviewed-by: Martin K. Petersen <martin.petersen at oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2018-12-19 3:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 3:42 [PATCH] nvme-core: add support for Write-Zeroes command Chaitanya Kulkarni
2018-12-18 16:52 ` Christoph Hellwig
2018-12-19 7:12 ` Chaitanya Kulkarni
2018-12-19 7:47 ` Christoph Hellwig
2018-12-19 3:34 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1r2eei40l.fsf@oracle.com \
--to=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.