From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: To: Omar Sandoval Cc: "Martin K. Petersen" , Bart Van Assche , "linux-scsi\@vger.kernel.org" , "James.Bottomley\@HansenPartnership.com" , "linux-block\@vger.kernel.org" , "osandov\@fb.com" , "hare\@suse.com" , "axboe\@kernel.dk" Subject: Re: [PATCH v4 10/10] scsi: Implement blk_mq_ops.show_rq() From: "Martin K. Petersen" References: <20170421234026.18970-1-bart.vanassche@sandisk.com> <20170421234026.18970-11-bart.vanassche@sandisk.com> <1493070575.3394.19.camel@sandisk.com> <20170424232359.GA21578@vader.DHCP.thefacebook.com> Date: Mon, 24 Apr 2017 19:33:44 -0400 In-Reply-To: <20170424232359.GA21578@vader.DHCP.thefacebook.com> (Omar Sandoval's message of "Mon, 24 Apr 2017 16:23:59 -0700") Message-ID: MIME-Version: 1.0 Content-Type: text/plain List-ID: Omar, > The debugfs infrastructure is already there, and it already supports > showing requests. Bart is just exposing the SCSI information. That's fine. I was merely objecting to the fact that we already have umpteen existing interfaces for displaying SCSI command information. -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH v4 10/10] scsi: Implement blk_mq_ops.show_rq() Date: Mon, 24 Apr 2017 19:33:44 -0400 Message-ID: References: <20170421234026.18970-1-bart.vanassche@sandisk.com> <20170421234026.18970-11-bart.vanassche@sandisk.com> <1493070575.3394.19.camel@sandisk.com> <20170424232359.GA21578@vader.DHCP.thefacebook.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:38068 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S978950AbdDXXfA (ORCPT ); Mon, 24 Apr 2017 19:35:00 -0400 In-Reply-To: <20170424232359.GA21578@vader.DHCP.thefacebook.com> (Omar Sandoval's message of "Mon, 24 Apr 2017 16:23:59 -0700") Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Omar Sandoval Cc: "Martin K. Petersen" , Bart Van Assche , "linux-scsi@vger.kernel.org" , "James.Bottomley@HansenPartnership.com" , "linux-block@vger.kernel.org" , "osandov@fb.com" , "hare@suse.com" , "axboe@kernel.dk" Omar, > The debugfs infrastructure is already there, and it already supports > showing requests. Bart is just exposing the SCSI information. That's fine. I was merely objecting to the fact that we already have umpteen existing interfaces for displaying SCSI command information. -- Martin K. Petersen Oracle Linux Engineering