From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Kai Mäkisara (Kolumbus)" <kai.makisara@kolumbus.fi>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, dgilbert@interlog.com,
"James.Bottomley@hansenpartnership.com"
<James.Bottomley@HansenPartnership.com>,
jmeneghi@redhat.com
Subject: Re: [PATCH v2 0/7] scsi: scsi_debug: Add more tape support
Date: Mon, 24 Feb 2025 20:44:17 -0500 [thread overview]
Message-ID: <yq1seo2bz0q.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <46401BB6-2688-4E8D-A730-77B7334AFE40@kolumbus.fi> ("Kai Mäkisara (Kolumbus)"'s message of "Mon, 24 Feb 2025 17:13:55 +0200")
Hi Kai!
> The command definitions in scsi_debug are common to all devices.
RSOC allows the device to report which fields in a given command are
valid (identified as "Usage data" below).
# sg_opcodes -o 0x8 /dev/sda
Opcode=0x08
Command_name: Read(6)
Command is supported [conforming to SCSI standard]
No command duration limit mode page
Multiple Logical Units (MLU): not reported
Usage data: 08 ff ff ff ff c7
SBC Read(6) and an SSC Read(6) don't have the exact same fields. And
consequently RSOC won't return the correct usage data for Read(6) in
tape mode. CDB byte 1 for tape should be 0x3 (SILI|FIXED) not 0xff
(Which I actually think is a bug, it should be 0x1f for SBC Read(6)
since bits 5-7 are reserved)).
Anyway. It's purely cosmetic. Nothing depends on this in practice, I
don't think.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2025-02-25 1:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 9:26 [PATCH v2 0/7] scsi: scsi_debug: Add more tape support Kai Mäkisara
2025-02-13 9:26 ` [PATCH v2 1/7] scsi: scsi_debug: First fixes for tapes Kai Mäkisara
2025-02-19 16:03 ` John Meneghini
2025-02-13 9:26 ` [PATCH v2 2/7] scsi: scsi_debug: Add READ BLOCK LIMITS and modify LOAD " Kai Mäkisara
2025-02-19 21:16 ` John Meneghini
2025-02-13 9:26 ` [PATCH v2 3/7] scsi: scsi_debug: Add write support with block lengths and 4 bytes of data Kai Mäkisara
2025-02-19 21:45 ` John Meneghini
2025-02-13 9:26 ` [PATCH v2 4/7] scsi: scsi_debug: Add read support and update locate for tapes Kai Mäkisara
2025-02-19 21:56 ` John Meneghini
2025-02-13 9:26 ` [PATCH v2 5/7] scsi: scsi_debug: Add compression mode page " Kai Mäkisara
2025-02-19 21:58 ` John Meneghini
2025-02-13 9:26 ` [PATCH v2 6/7] scsi: scsi_debug: Reset tape setting at device reset Kai Mäkisara
2025-02-19 21:58 ` John Meneghini
2025-02-13 9:26 ` [PATCH v2 7/7] scsi: scsi_debug: Add support for partitioning the tape Kai Mäkisara
2025-02-19 22:17 ` John Meneghini
2025-02-13 16:12 ` [PATCH v2 0/7] scsi: scsi_debug: Add more tape support John Meneghini
2025-02-19 22:32 ` John Meneghini
2025-02-24 3:19 ` Martin K. Petersen
2025-02-24 15:13 ` "Kai Mäkisara (Kolumbus)"
2025-02-25 1:44 ` Martin K. Petersen [this message]
2025-03-04 3:19 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1seo2bz0q.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dgilbert@interlog.com \
--cc=jmeneghi@redhat.com \
--cc=kai.makisara@kolumbus.fi \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.