From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH] scsi: lpfc: Avoid unused function warnings Date: Thu, 06 Jun 2019 17:55:16 -0400 Message-ID: References: <20190606052421.103469-1-natechancellor@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20190606052421.103469-1-natechancellor@gmail.com> (Nathan Chancellor's message of "Wed, 5 Jun 2019 22:24:21 -0700") Sender: linux-kernel-owner@vger.kernel.org To: Nathan Chancellor Cc: James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, YueHaibing List-Id: linux-scsi@vger.kernel.org Nathan, > When building powerpc pseries_defconfig or powernv_defconfig: > > drivers/scsi/lpfc/lpfc_nvmet.c:224:1: error: unused function > 'lpfc_nvmet_get_ctx_for_xri' [-Werror,-Wunused-function] > drivers/scsi/lpfc/lpfc_nvmet.c:246:1: error: unused function > 'lpfc_nvmet_get_ctx_for_oxid' [-Werror,-Wunused-function] > > These functions are only compiled when CONFIG_NVME_TARGET_FC is enabled. > Use that same condition so there is no more warning. While the fixes > commit did not introduce these functions, it caused these warnings. Applied to 5.3/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering