All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] scsi: cxgb4i: silence overflow warning in t4_uld_rx_handler()
Date: Tue, 10 Apr 2018 02:09:37 +0000	[thread overview]
Message-ID: <yq1sh8324ny.fsf@oracle.com> (raw)
In-Reply-To: <20180403085222.GA19927@mwanda>


Dan,

> Smatch marks skb->data as untrusted so it complains that there is a
> potential overflow here:
>
> 	drivers/scsi/cxgbi/cxgb4i/cxgb4i.c:2111 t4_uld_rx_handler()
> 	error: buffer overflow 'cxgb4i_cplhandlers' 239 <= 255.
>
> In this case, skb->data comes from the hardware or firmware so it's not
> going to overflow unless there is a firmware bug.

Applied to 4.17/scsi-fixes, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

      reply	other threads:[~2018-04-10  2:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-03  8:52 [PATCH v2] scsi: cxgb4i: silence overflow warning in t4_uld_rx_handler() Dan Carpenter
2018-04-10  2:09 ` Martin K. Petersen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1sh8324ny.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.