From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Kashyap.Desai@avagotech.com
Cc: linux-scsi@vger.kernel.org, hch@infradead.org, elliott@hp.com,
jbottomley@parallels.com, aacraid@adaptec.com,
bvanassche@acm.org
Subject: Re: [PATCH/RESEND] scsi.mq: Added use_cmd_list flag in scsi_host to reduce lock contention
Date: Wed, 20 Aug 2014 11:47:02 -0400 [thread overview]
Message-ID: <yq1sikrtb7t.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <201408201357.s7KDvDeL021549@palmhbs0.lsi.com> (Kashyap Desai's message of "Wed, 20 Aug 2014 19:24:33 +0530")
>>>>> "Kashyap" == <Kashyap.Desai@avagotech.com> writes:
Kashyap> Comment provided by Bart Van and Chris H is addressed in this
Kashyap> patch. Add use_cmd_list flag in scsi_host to indicate scs.mq
Kashyap> stack to keep track of cmd_list per sdev.
Kashyap> Default behaviour is not to keep track of cmd_list per sdev, as
Kashyap> this may introduce lock contention. (overhead is more on
Kashyap> multi-node NUMA.)
Kashyap> Patch is tested using megaraid_sas driver with "use_cmd_list"
Kashyap> value set to 1 and 0. Added MAINTAINER of Adaptec to verify
Kashyap> changes.
Kashyap> Signed-off-by: Kashyap Desai <kashyap.desai@avagotech.com>
Looks good to me.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2014-08-20 15:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 13:54 [PATCH/RESEND] scsi.mq: Added use_cmd_list flag in scsi_host to reduce lock contention Kashyap.Desai
2014-08-20 15:47 ` Martin K. Petersen [this message]
2014-08-22 16:04 ` Bart Van Assche
2014-08-24 16:26 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2014-08-20 13:28 Kashyap.Desai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1sikrtb7t.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=Kashyap.Desai@avagotech.com \
--cc=aacraid@adaptec.com \
--cc=bvanassche@acm.org \
--cc=elliott@hp.com \
--cc=hch@infradead.org \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.