From: "Martin K. Petersen" <mkp@kernel.org>
To: Haotian Zhang <vulab@iscas.ac.cn>
Cc: Ram Vegesna <ram.vegesna@broadcom.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <mkp@kernel.org>,
James Smart <jsmart2021@gmail.com>,
Daniel Wagner <dwagner@suse.de>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: elx: libefc: fix resources leak in efcport_init() error path
Date: Fri, 23 Oct 2026 22:22:13 -0400 [thread overview]
Message-ID: <yq1tsmbaldj.fsf@mail.kernel.org> (raw)
In-Reply-To: <20261008185403.2791781-1-vulab@iscas.ac.cn>
Haotian,
> efcport_init() creates efc->node_pool and efc->node_dma_pool before
> allocating efc->els_io_pool. When the latter allocation fails it returns
> -ENOMEM without releasing the node dma pool or the node pool, leaking
> both. The caller efct_efclib_config() only logs the error and
> efct_device_attach() failure path never calls efcport_destroy(), so the
> resources are never freed.
Applied to 7.4/scsi-staging, thanks!
--
Martin K. Petersen
next prev parent reply other threads:[~2026-10-24 2:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 18:54 [PATCH] scsi: elx: libefc: fix resources leak in efcport_init() error path Haotian Zhang
2026-10-08 19:04 ` sashiko-bot
2026-10-09 6:10 ` Krzysztof Kozlowski
2026-10-12 9:36 ` Daniel Wagner
2026-10-24 2:22 ` Martin K. Petersen [this message]
2026-10-29 2:02 ` Martin K. Petersen (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1tsmbaldj.fsf@mail.kernel.org \
--to=mkp@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dwagner@suse.de \
--cc=jsmart2021@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ram.vegesna@broadcom.com \
--cc=target-devel@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.