From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: njavali@marvell.com
Cc: Vladimir Riabchun <ferr.lambarginio@gmail.com>,
GR-QLogic-Storage-Upstream@marvell.com,
James.Bottomley@hansenpartnership.com,
martin.petersen@oracle.com, skashyap@marvell.com,
himanshu.madhani@oracle.com, qutran@marvell.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: qla2xxx: Completely fix fcport double free
Date: Sat, 28 Feb 2026 20:15:36 -0500 [thread overview]
Message-ID: <yq1tsv01hdg.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <aYsDln9NFQQsPDgg@vova-pc> (Vladimir Riabchun's message of "Tue, 10 Feb 2026 11:08:22 +0100")
Nilesh,
> In qla24xx_els_dcmd_iocb sp->free is set to qla2x00_els_dcmd_sp_free.
> When an error happens, this function is called by qla2x00_sp_release,
> when kref_put releases the first and the last reference.
>
> qla2x00_els_dcmd_sp_free frees fcport by calling qla2x00_free_fcport.
> Doing it one more time after kref_put is a bad idea.
Please review!
https://lore.kernel.org/all/aYsDln9NFQQsPDgg@vova-pc/
--
Martin K. Petersen
next prev parent reply other threads:[~2026-03-01 1:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 10:08 [PATCH] scsi: qla2xxx: Completely fix fcport double free Vladimir Riabchun
2026-02-23 10:49 ` Vladimir Riabchun
2026-03-01 1:15 ` Martin K. Petersen [this message]
2026-03-01 12:08 ` [EXTERNAL] " Nilesh Javali
2026-03-11 2:09 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1tsv01hdg.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=ferr.lambarginio@gmail.com \
--cc=himanshu.madhani@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=njavali@marvell.com \
--cc=qutran@marvell.com \
--cc=skashyap@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.