From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, rostedt@goodmis.org,
Uladzislau Rezki <urezki@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 rcu 12/16] scsi/scsi_error: Use call_rcu_flush() instead of call_rcu()
Date: Fri, 25 Nov 2022 21:42:58 -0500 [thread overview]
Message-ID: <yq1tu2mmo7w.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20221122010421.3799681-12-paulmck@kernel.org> (Paul E. McKenney's message of "Mon, 21 Nov 2022 17:04:17 -0800")
Paul,
> Therefore, make scsi_eh_scmd_add() use call_rcu_flush() in order to
> revert to the old behavior.
[...]
> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> index 6995c89792300..634672e67c81f 100644
> --- a/drivers/scsi/scsi_error.c
> +++ b/drivers/scsi/scsi_error.c
> @@ -312,7 +312,7 @@ void scsi_eh_scmd_add(struct scsi_cmnd *scmd)
> * Ensure that all tasks observe the host state change before the
> * host_failed change.
> */
> - call_rcu(&scmd->rcu, scsi_eh_inc_host_failed);
> + call_rcu_flush(&scmd->rcu, scsi_eh_inc_host_failed);
> }
>
> /**
OK with me.
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-11-26 2:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 1:04 [PATCH rcu 0/16 Lazy call_rcu() updates for v6.2 Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 01/16] rcu: Simplify rcu_init_nohz() cpumask handling Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 02/16] rcu: Fix late wakeup when flush of bypass cblist happens Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 03/16] rcu: Fix missing nocb gp wake on rcu_barrier() Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 04/16] rcu: Make call_rcu() lazy to save power Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 05/16] rcu: Refactor code a bit in rcu_nocb_do_flush_bypass() Paul E. McKenney
2022-11-23 15:59 ` Frederic Weisbecker
2022-11-23 17:54 ` Paul E. McKenney
2022-11-24 1:00 ` Joel Fernandes
2022-11-22 1:04 ` [PATCH v2 rcu 06/16] rcu: Shrinker for lazy rcu Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 07/16] rcuscale: Add laziness and kfree tests Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 08/16] percpu-refcount: Use call_rcu_flush() for atomic switch Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 09/16] rcu/sync: Use call_rcu_flush() instead of call_rcu Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 10/16] rcu/rcuscale: Use call_rcu_flush() for async reader test Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 11/16] rcu/rcutorture: Use call_rcu_flush() where needed Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 12/16] scsi/scsi_error: Use call_rcu_flush() instead of call_rcu() Paul E. McKenney
2022-11-26 0:11 ` Bart Van Assche
2022-11-28 21:39 ` Paul E. McKenney
2022-11-26 2:42 ` Martin K. Petersen [this message]
2022-11-22 1:04 ` [PATCH v2 rcu 13/16] workqueue: Make queue_rcu_work() use call_rcu_flush() Paul E. McKenney
2022-11-22 1:09 ` Tejun Heo
2022-11-22 1:23 ` Paul E. McKenney
2022-11-22 1:37 ` Tejun Heo
2022-11-22 1:52 ` Paul E. McKenney
2022-11-22 21:30 ` Tejun Heo
2022-11-22 1:04 ` [PATCH v2 rcu 14/16] rxrpc: Use call_rcu_flush() instead of call_rcu() Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 15/16] net: Use call_rcu_flush() for dst_release() Paul E. McKenney
2022-11-22 1:04 ` [PATCH v2 rcu 16/16] net: devinet: Reduce refcount before grace period Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1tu2mmo7w.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=joel@joelfernandes.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.