From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Anatoliy Glagolev <glagolig@gmail.com>
Cc: aglagolev@purestorage.com, adailey@purestorage.com,
jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, hch@lst.de,
qla2xxx-upstream@qlogic.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: qla2xxx: deadlock by configfs_depend_item
Date: Wed, 19 Dec 2018 21:27:23 -0500 [thread overview]
Message-ID: <yq1tvj9exv8.fsf@oracle.com> (raw)
In-Reply-To: <1544140125-3060-1-git-send-email-glagolig@gmail.com> (Anatoliy Glagolev's message of "Thu, 6 Dec 2018 16:48:45 -0700")
Anatoliy,
> The intent of invoking configfs_depend_item in commit 7474f52a82d51
> ("tcm_qla2xxx: Perform configfs depend/undepend for base_tpg") was to
> prevent a physical Fibre Channel port removal when virtual (NPIV)
> ports announced through that physical port are active. The change
> does not work as expected: it makes enabled physical port dependent on
> target configfs subsystem (the port's parent), something the configfs
> guarantees anyway.
>
> Besides, scheduling work in a worker thread and waiting for the work's
> completion is not really a valid workaround for the requirement not to
> call configfs_depend_item from a configfs callback: the call
> occasionally deadlocks.
>
> Thus, removing configfs_depend_item calls does not break anything and
> fixes the deadlock problem.
Applied to 4.21/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2018-12-20 2:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 23:48 [PATCH] scsi: qla2xxx: deadlock by configfs_depend_item Anatoliy Glagolev
2018-12-13 21:53 ` Anatoliy Glagolev
2018-12-20 2:27 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1tvj9exv8.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=adailey@purestorage.com \
--cc=aglagolev@purestorage.com \
--cc=glagolig@gmail.com \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=qla2xxx-upstream@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.